Skip to content

Conversation

@alexazarh
Copy link
Contributor

@alexazarh alexazarh commented May 22, 2016

Description

  1. Added queued state handling to SyncroniousTaskWaiter
  2. refactored vmOmiService to use SyncroniousTaskWaiter

Breaking

NO


This change is Reviewable

2. refactored vmOmiService to use SyncroniousTaskWaiter
@razaba
Copy link
Contributor

razaba commented May 22, 2016

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


package/cloudshell/cp/vcenter/common/vcenter/task_waiter.py, line 20 [r1] (raw file):

        while task.info.state == vim.TaskInfo.State.running or task.info.state == vim.TaskInfo.State.queued:
            time.sleep(2)

I think that will be more readable
while task.info.state in [vim.TaskInfo.State.running , vim.TaskInfo.State.queued]:


Comments from Reviewable

@alexazarh
Copy link
Contributor Author

Review status: 5 of 6 files reviewed at latest revision, 1 unresolved discussion.


package/cloudshell/cp/vcenter/common/vcenter/task_waiter.py, line 20 [r1] (raw file):

Previously, razaba (Raz Abadi) wrote…

I think that will be more readable
while task.info.state in [vim.TaskInfo.State.running , vim.TaskInfo.State.queued]:

Done.

Comments from Reviewable

@razaba
Copy link
Contributor

razaba commented May 22, 2016

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@razaba razaba merged commit aab5e1e into develop May 22, 2016
@razaba razaba removed the ready label May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants