Skip to content

task #722 ability to turn promiscuous mode on off#800

Merged
GilGald merged 4 commits intodevelopfrom
feature/apiddubny_722_ability_to_turn_promiscuous_mode_on_off
Sep 22, 2016
Merged

task #722 ability to turn promiscuous mode on off#800
GilGald merged 4 commits intodevelopfrom
feature/apiddubny_722_ability_to_turn_promiscuous_mode_on_off

Conversation

@anthony-poddubny
Copy link
Copy Markdown

@anthony-poddubny anthony-poddubny commented Sep 20, 2016

Description

  • add "promiscuous_mode" attribute to the vCenter model
  • use "promiscuous_mode" for enable/disable promiscuous mode for the newly created port groups

Breaking

NO


This change is Reviewable

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 20, 2016

Coverage Status

Coverage increased (+0.01%) to 85.825% when pulling c26a1c9 on feature/apiddubny_722_ability_to_turn_promiscuous_mode_on_off into 5d6efe0 on develop.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 20, 2016

Coverage Status

Coverage increased (+0.01%) to 85.825% when pulling c26a1c9 on feature/apiddubny_722_ability_to_turn_promiscuous_mode_on_off into 5d6efe0 on develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 85.83% when pulling b87335b on feature/apiddubny_722_ability_to_turn_promiscuous_mode_on_off into c03a529 on develop.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 85.83% when pulling b87335b on feature/apiddubny_722_ability_to_turn_promiscuous_mode_on_off into c03a529 on develop.

@GilGald
Copy link
Copy Markdown
Contributor

GilGald commented Sep 22, 2016

Reviewed 14 of 14 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@GilGald GilGald merged commit 21c8fb1 into develop Sep 22, 2016
@anthony-poddubny anthony-poddubny deleted the feature/apiddubny_722_ability_to_turn_promiscuous_mode_on_off branch October 12, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants