Fix mypy type annotations in Python project templates#2405
Merged
AlexCatarino merged 2 commits intoMay 13, 2026
Merged
Conversation
- Annotate `_fundamental: list[Symbol]` in the QuiverQuantCongress chained-universe template so mypy can infer the element type. - Use the pythonnet generic-indexer form `cache.get_data[TradeBar]()` in the custom-models template so the return type carries through.
Annotate `_get_features_and_labels`, the inner `loss_mse`, and `on_data` so the file passes the strict-mypy syntax check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fundamental: list[Symbol]in the QuiverQuantCongress chained-universe template so mypy can infer the element type.cache.get_data[TradeBar]()in the custom-models template so theTradeBarreturn type carries through (avoidsno-any-return)._get_features_and_labels, the innerloss_mse, andon_datain the ai template so the file passes strict mypy.Test plan
python project-templates/python/run_syntax_check.py— 100% pass across all 72 templates.