Skip to content

Fix 403 link warnings#2558

Merged
DerekMelchin merged 2 commits into
QuantConnect:masterfrom
DerekMelchin:bug-1575-fix-403-warnings
Jun 22, 2026
Merged

Fix 403 link warnings#2558
DerekMelchin merged 2 commits into
QuantConnect:masterfrom
DerekMelchin:bug-1575-fix-403-warnings

Conversation

@DerekMelchin

Copy link
Copy Markdown
Collaborator

Description

Re-check 401/403 links with a browser-impersonating client (curl_cffi) before warning. Bot-blocked-but-valid links are cleared; a browser-confirmed 404 is escalated to a failing error so dead links can't hide behind a 403.

Related Issue

#1575

Motivation and Context

Many third-party sites (FINRA, Coinbase, Bitfinex, etc.) return 401/403 to plain HTTP clients on valid links, flooding the link checker with false warnings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • New feature (non-breaking change which adds functionality)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

DerekMelchin and others added 2 commits June 22, 2026 16:19
Many third-party sites (FINRA, Coinbase, Bitfinex, CoinAPI, BLS, ByBit, ...)
return 401/403 to plain HTTP clients based on TLS/header fingerprinting even
though the links are valid. Re-check those responses with curl_cffi (Chrome TLS
impersonation) before warning, so bot-blocked-but-valid links no longer generate
noise. A 429 is treated as reachable (server is live); 404/410 stays flagged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
When the browser re-check of a 401/403 reveals a real 404/410, record it as a
404 error instead of a 403 warning, so a genuinely dead link can't hide behind a
bot-block and pass CI. Links that still can't be verified stay non-failing
warnings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@DerekMelchin DerekMelchin merged commit 506870f into QuantConnect:master Jun 22, 2026
@DerekMelchin DerekMelchin deleted the bug-1575-fix-403-warnings branch June 22, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant