Skip to content

Adds source_at to Data Class #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martin-Molinero merged 2 commits into from
Jul 1, 2024
Merged

Adds source_at to Data Class #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22ad6eb
Adds `source_at` to Data Class
AlexCatarino Jun 28, 2024
1af3e63
Fixes GitHub Action to Free More Space
AlexCatarino Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
uses: actions/checkout@v2

- name: Free space
run: df -h && rm -rf /opt/hostedtoolcache* && df -h
run: df -h && sudo rm -rf /usr/local/lib/android && sudo rm -rf /opt/ghc && rm -rf /opt/hostedtoolcache* && df -h

- name: Pull Foundation Image
uses: addnab/docker-run-action@v3
Expand Down
6 changes: 5 additions & 1 deletion RegalyticsRegulatoryArticle.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ public class RegalyticsRegulatoryArticle : BaseData
[JsonProperty(PropertyName = "rule_effective_date")]
public DateTime? RuleEffectiveDate { get; set; }

[JsonProperty(PropertyName = "sourced_at")]
public DateTime SourcedAt { get; set; }

[JsonProperty(PropertyName = "latest_update")]
public DateTime LatestUpdate { get; set; }

Expand Down Expand Up @@ -158,7 +161,8 @@ public override BaseData Clone()
Agencies = Agencies,
Sector = Sector,
AnnouncementUrl = AnnouncementUrl,
CreatedAt = CreatedAt
CreatedAt = CreatedAt,
SourcedAt = SourcedAt
};
}

Expand Down
10 changes: 7 additions & 3 deletions tests/RegalyticsRegulatoryArticleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public void BackwardCompatibilityToV2()
var config = new SubscriptionDataConfig(instance.GetType(), Symbol.None, Resolution.Daily, TimeZones.Utc, TimeZones.Utc, false, false, false);
var data = instance.Reader(config, line, new DateTime(2024, 2, 12), false) as RegalyticsRegulatoryArticle;
Assert.AreEqual("2051381", data.Id);
Assert.AreEqual(DateTime.MinValue, data.SourcedAt);
}

private void AssertAreEqual(object expected, object result, bool filterByCustomAttributes = false)
Expand Down Expand Up @@ -111,7 +112,8 @@ private BaseData CreateNewInstance()
Agencies = new List<string>{"string"},
Sector = new List<Dictionary<string, string>> { new Dictionary<string, string> { { "key", "value" } } },
AnnouncementUrl = "string",
CreatedAt = DateTime.MinValue
CreatedAt = DateTime.MinValue,
SourcedAt = DateTime.MinValue,
};
}

Expand Down Expand Up @@ -145,7 +147,8 @@ private BaseData CreateNewCollectionInstance()
Agencies = new List<string>{"string"},
Sector = new List<Dictionary<string, string>> { new Dictionary<string, string> { { "key", "value" } } },
AnnouncementUrl = "string",
CreatedAt = DateTime.MinValue
CreatedAt = DateTime.MinValue,
SourcedAt = DateTime.MinValue
},
new RegalyticsRegulatoryArticle
{
Expand Down Expand Up @@ -173,7 +176,8 @@ private BaseData CreateNewCollectionInstance()
Agencies = new List<string>{"string"},
Sector = new List<Dictionary<string, string>> { new Dictionary<string, string> { { "key", "value" } } },
AnnouncementUrl = "string",
CreatedAt = DateTime.MinValue
CreatedAt = DateTime.MinValue,
SourcedAt = DateTime.MinValue
}
};
}
Expand Down