Update process.py script to work with new API changes#2
Closed
Update process.py script to work with new API changes#2
Conversation
* Adjust BaseData model EndTime parsing and calculation
Martin-Molinero
approved these changes
Aug 30, 2021
Member
Martin-Molinero
left a comment
Martin-Molinero
left a comment
There was a problem hiding this comment.
Cool! minor questions
| article['agencies'] = [agency['name'] for agency in article['agencies']] | ||
|
|
||
| date = datetime.strptime(article['latest_update'], '%Y-%m-%d') | ||
| date = datetime.strptime(article['created_at'], '%Y-%m-%dT%H:%M:%S.%f%z').astimezone(timezone.utc) |
Member
There was a problem hiding this comment.
Is Regalytics returning the data sorted by 'created_at' ?
Martin-Molinero
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aslo adjusts Regalytics BaseData EndTime parsing and timezone, since
created_timeis returned in a time that contains the offset to UTC.Adjusts the resolution to
AllResolutionsfor ergonomics and because the timestamp precision of thecreated_timefield is 1 microsecond