Fix broken --config command-line argument#2251
Merged
Martin-Molinero merged 2 commits intoJul 16, 2018
Merged
Conversation
Reset the configuration settings at the beginning of program execution, so that, when passing a custom --config argument to the program, values from that file are read instead of the default config file.
4 tasks
Member
|
Hi @mblouin02! |
Adressing Martin Molinero's comment from this pull request: QuantConnect#2251 (comment)
Contributor
Author
|
Hi @Martin-Molinero, I did the change that you recommended. Feel free to comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reset the configuration settings at the beginning of program
execution, so that, when passing a custom --config argument
to the program, values from that file are read instead of the
default config file.
Related Issue
#2249
Motivation and Context
Config file argument was not used in the program.
How Has This Been Tested?
Reproduced the steps 1-7 described in #2249, and confirmed that the value is now correctly read.
Types of changes
Checklist:
bug-<issue#>-<descriptionorfeature-<issue#>-<description>