Skip to content

Fix option settlement cash profit#8520

Merged
Martin-Molinero merged 1 commit intoQuantConnect:masterfrom
Martin-Molinero:bug-8493-cash-settlement
Jan 13, 2025
Merged

Fix option settlement cash profit#8520
Martin-Molinero merged 1 commit intoQuantConnect:masterfrom
Martin-Molinero:bug-8493-cash-settlement

Conversation

@Martin-Molinero
Copy link
Copy Markdown
Member

Description

  • Fix so that option cash settlement impacts profit records. Updating existing and adding new tests

Related Issue

Closes #8493

Motivation and Context

N/A

Requires Documentation Change

N/A

How Has This Been Tested?

Existing and new tests updates

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

- Fix so that option cash settlement impacts profit records. Updating
  existing and adding new tests
@Martin-Molinero Martin-Molinero force-pushed the bug-8493-cash-settlement branch from 1dc4b19 to 96fba27 Compare January 13, 2025 15:23
@Martin-Molinero Martin-Molinero merged commit 6982f67 into QuantConnect:master Jan 13, 2025
@Martin-Molinero Martin-Molinero deleted the bug-8493-cash-settlement branch January 13, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Net Profit Doesn't Account for Index Assignment

1 participant