Skip to content

Update SPDB - Bybit#8563

Merged
Martin-Molinero merged 1 commit intoQuantConnect:masterfrom
JosueNina:bug-8556-spdb-is-not-correct
Jan 29, 2025
Merged

Update SPDB - Bybit#8563
Martin-Molinero merged 1 commit intoQuantConnect:masterfrom
JosueNina:bug-8556-spdb-is-not-correct

Conversation

@JosueNina
Copy link
Collaborator

@JosueNina JosueNina commented Jan 28, 2025

Description

Update symbol properties database for Bybit

Related Issue

Closes #8556
Related QuantConnect/Lean.Brokerages.ByBit#29

Motivation and Context

Updates the symbol properties database to fix pairs in Bybit

Requires Documentation Change

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero Martin-Molinero merged commit c3530a6 into QuantConnect:master Jan 29, 2025
6 of 7 checks passed
@bemda
Copy link

bemda commented Feb 6, 2025

Description

Update symbol properties database for Bybit

Related Issue

Closes #8556 Related QuantConnect/Lean.Brokerages.ByBit#29

Motivation and Context

Updates the symbol properties database to fix pairs in Bybit

Requires Documentation Change

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Hello Team-QC,
you were fixing a bug I reported. Thank you for your helpfulness.

I'm looking at your commits and see that you have removed TESNET from bybit bybit-api-url.

However, for bybit-websocket-url you have left TESTNET. Is that okay ? Just checking.

Have a good day

COMMIT:

removed "bybit-api-url": "https://api-testnet.bybit.com/",
added "bybit-api-url": "https://api.bybit.com/",
nochages "bybit-websocket-url": "wss://stream-testnet.bybit.com",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SPDB is not correct

3 participants