-
-
Notifications
You must be signed in to change notification settings - Fork 4k
feature: Klinger Volume Oscillator #8811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Klinger Volume Oscillator #8811
Conversation
Martin-Molinero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mattfair! Welcome to Lean 🚀
Leaving a few requests, the biggest is trying to simplify the implementation a bit, simpler always 10x better.
Also something that's missing from this PR is the helper method in QCAlgorithm.Indicators.cs, there are plenty merged indicator PRs to take a look at for this 👍
…ta, refactor code to make easier to follow
…t, fix IsReady and WarmUpPeriod
Martin-Molinero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, a few more minor comments
Martin-Molinero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🚀
Description
Implements Klinger Volume Oscillator
Related Issue
Closes #8125
Motivation and Context
Implements the volume oscillator
Requires Documentation Change
Update any documentation for supported indicators.
How Has This Been Tested?
Verified against generated KVO(5, 10) from talipp
Lean/Tests/TestData/generate_reference_data_from_talipp.py
Line 158 in 54e58c6
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>