Skip to content

Respect caller-provided User-Agent in Api.DownloadBytes #9458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martin-Molinero merged 1 commit into from
May 6, 2026
+7 −3
Merged

Respect caller-provided User-Agent in Api.DownloadBytes #9458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Api/Api.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,9 +1043,6 @@ public virtual byte[] DownloadBytes(string address, IEnumerable<KeyValuePair<str
{
client.Value.DefaultRequestHeaders.Clear();

// Add a user agent header in case the requested URI contains a query.
client.Value.DefaultRequestHeaders.TryAddWithoutValidation("user-agent", "QCAlgorithm.Download(): User Agent Header");

if (headers != null)
{
foreach (var header in headers)
Expand All @@ -1054,6 +1051,13 @@ public virtual byte[] DownloadBytes(string address, IEnumerable<KeyValuePair<str
}
}

// Add a user agent header in case the requested URI contains a query, unless the caller already provided one.
// DefaultRequestHeaders.Contains matches header names case-insensitively per the HTTP spec.
if (!client.Value.DefaultRequestHeaders.Contains("User-Agent"))
{
client.Value.DefaultRequestHeaders.TryAddWithoutValidation("User-Agent", "QCAlgorithm.Download(): User Agent Header");
}

if (!userName.IsNullOrEmpty() || !password.IsNullOrEmpty())
{
var credentials = Convert.ToBase64String(Encoding.ASCII.GetBytes($"{userName}:{password}"));
Expand Down
Loading