Retain live statistics chart samples#9484
Open
aiSynergy37 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Retains the live daily chart samples used by statistics generation before chart data is trimmed for streaming updates. The retained samples are merged into the chart clones used for live statistics so metrics such as PSR continue to have the full daily history.
Related Issue
Fixes #9477
Motivation and Context
Live chart cleanup keeps recent streamed chart data, but daily statistics only add a few samples over that same window. After trimming, statistics generation can see too few daily points and emit default zero values for risk metrics.
Requires Documentation Change
No.
How Has This Been Tested?
dotnet build Tests\QuantConnect.Tests.csproj --no-restore -v minimal /p:RunAnalyzers=falsedotnet testrun compiled the test assembly, then the Windows test host aborted during Python.NET GIL finalization before NUnit reported the result.Types of Changes