Skip to content

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented May 8, 2023

This PR:

cc: @jstac

  • review build in the morning before merging

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
🔨 Latest commit ea5bad7
🔍 Latest deploy log https://app.netlify.com/sites/incomparable-parfait-2417f8/deploys/6458de95ce5d3200087ac025
😎 Deploy Preview https://deploy-preview-47--incomparable-parfait-2417f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 8, 2023

@github-actions github-actions bot temporarily deployed to pull request May 8, 2023 11:52 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented May 8, 2023

@HengchengZhang is there a way to fix

(           intro: line   18) broken    https://quantecon.org/projects/#filter=lecture - Anchor 'filter=lecture' not found

I added this link to replace the old one on the intro page but it uses an anchor to run a query.

@HengchengZhang
Copy link
Member

Hi @mmcky, I'm not sure where this link should be directed to. Is that https://quantecon.org/python-lectures/?

@mmcky
Copy link
Contributor Author

mmcky commented May 8, 2023

Hi @mmcky, I'm not sure where this link should be directed to. Is that https://quantecon.org/python-lectures/?

Sorry @HengchengZhang -- I wasn't clear. The link is correct but needs the anchor. Will that cause problems with the sphinx linkchecker from your investigations?

@mmcky
Copy link
Contributor Author

mmcky commented May 8, 2023

@jstac as this impacts widely I will merge this now. I'll help with any merge conflict on #49

@mmcky mmcky merged commit f559857 into main May 8, 2023
@mmcky mmcky deleted the harmonise branch May 8, 2023 23:25
@HengchengZhang
Copy link
Member

That should not be the problem with link checker, our QuantEcon links only returns error when it's actually broken.

So I think there's something wrong with this anchor or the use of anchor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants