Skip to content

Conversation

@jstac
Copy link
Contributor

@jstac jstac commented Mar 12, 2023

Shifted from in-work to lectures, added to TOC, corrected spelling and minor typos

@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 92f949a
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/6418d582fda6de0008d7ea9c
😎 Deploy Preview https://deploy-preview-130--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jstac
Copy link
Contributor Author

jstac commented Mar 12, 2023

Text to-do

  • heading levels need to be consistent (see build error)
  • full spell check
  • headings need to be capitalized (to fit with other lectures)
  • search for ^T and replace with ^\top

Code to-do

  • spaces around * and @ (closer to PEP8)
  • camel case for classes, no underscore (consistent with PEP8)

@jstac
Copy link
Contributor Author

jstac commented Mar 16, 2023

@mmcky , I need to work on some of the maths in this lecture tomorrow. Could you or @Smit-create please get it to the stage where it builds in JB, which will make it easier for me to build and edit?

@Smit-create
Copy link
Member

Thanks, @jstac. I'm looking into the build failure issue.

@mmcky
Copy link
Contributor

mmcky commented Mar 16, 2023

Thanks, @jstac. I'm looking into the build failure issue.

@Smit-create you may want to merge in the latest main re build failures.

@github-actions github-actions bot temporarily deployed to commit March 16, 2023 12:01 Inactive
@Smit-create
Copy link
Member

@jstac @mmcky Thanks. The CI is green again. John, I made a few header changes just to check the CI and make it pass. Please feel to reorder them as you need in the lecture flow.

@jstac
Copy link
Contributor Author

jstac commented Mar 16, 2023

Thanks @Smit-create !

@github-actions github-actions bot temporarily deployed to commit March 20, 2023 21:55 Inactive
@jstac
Copy link
Contributor Author

jstac commented Mar 20, 2023

This PR adds @thomassargent30 's fundamental supply and demand lecture, which has now been broken into three parts

  • intro_supply_demand.md (scalar case)
  • supply_demand_multiple_goods.md (shifting to multple goods)
  • supply_demand_heterogeneity.md (adding heterogeneity)

I'm going to merge this into main and then open separate issues for each lecture to get them ready for publishing.

@jstac jstac merged commit e9c4c5f into main Mar 20, 2023
@jstac jstac deleted the add-sd branch March 20, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants