Skip to content

Conversation

@jstac
Copy link
Contributor

@jstac jstac commented Feb 17, 2023

No description provided.

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit add02bc
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/63fff8e360949b0008abd00c
😎 Deploy Preview https://deploy-preview-96--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

$$(topshares)
with $[\cdot]$ as the greatest integer function, which rounds-off the real number inside the square bracket down to the integer less than the number.
Here $[\cdot]$ is the greatest integer function, which rounds-off the real
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shlff Here and above please use the correct latex symbol: https://latex-tutorial.com/floor-latex/

@jstac
Copy link
Contributor Author

jstac commented Feb 17, 2023

@shlff Can you please

  • explain the line ginis_li_new[5] = (ginis_li[4] + ginis_li[6]) / 2 and the one above
  • explain in one line the difference between labor income and total income.

@jstac
Copy link
Contributor Author

jstac commented Feb 17, 2023

@shlff Could you please break the US gini time series plot into two plots

  • one for wealth
  • one for the two forms of labor income.

This will make the strong U shape in the wealth time series clearer.

@github-actions github-actions bot temporarily deployed to commit February 17, 2023 21:23 Inactive
@shlff
Copy link
Member

shlff commented Feb 17, 2023

Thanks for your excellent comments and rewriting the introduction @jstac . It looks attractive to me.

Please find my modifications in the comment above.

@github-actions github-actions bot temporarily deployed to commit February 17, 2023 22:48 Inactive
@github-actions github-actions bot temporarily deployed to commit February 17, 2023 22:50 Inactive
@mmcky
Copy link
Contributor

mmcky commented Mar 1, 2023

@shlff if this is ready can you take it with the ready label?

@shlff
Copy link
Member

shlff commented Mar 1, 2023

Sure @mmcky .

Hi @jstac I‘ve pushed commits according to your comments and this PR is ready for review.

I will put a ready label once you confirm or I will modify it accordingly.

@jstac
Copy link
Contributor Author

jstac commented Mar 1, 2023

Thanks @shlff .

I can't see your edits in the file diffs. Can you see them? (Click "Files Changed")

@shlff
Copy link
Member

shlff commented Mar 2, 2023

Thanks @shlff .

I can't see your edits in the file diffs. Can you see them? (Click "Files Changed")

Thanks @jstac .

Please find my edits from the following link (I've selected the changes from my commits only):


$$
T(p) = 1 - L (1-p)
\approx \frac{\sum_{j\geq i} w_j}{ \sum_{j \leq n} w_j}, \quad i = [n (1-p)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you need to change to \floor and \rfloor in this line?

Here $[\cdot]$ is the greatest integer function, which rounds-off the real
number inside the square bracket down to the integer less than the number.
Here $\lfloor \cdot \rfloor$ is the floor function, which rounds-off the real
number inside the square bracket down to the integer less than or equal to the number.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...which rounds any number down to the integer..."
"...the number" -> "that number"

Let's plot the Gini coefficients for net wealth, labor income and total income.

```{code-cell} ipython3
# use the average to replace an outlier in labor income gini
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the average" -> "an average"

@jstac
Copy link
Contributor Author

jstac commented Mar 2, 2023

Thanks @shlff , please see my comments

@shlff
Copy link
Member

shlff commented Mar 2, 2023

Thanks @shlff , please see my comments

Thanks @jstac . Please find my modifications according to your comments.

@jstac
Copy link
Contributor Author

jstac commented Mar 2, 2023

It's hard to check the diffs on this.

Did you delete "inside the square bracket" as requested? The sentence should read "...which rounds any number down to the integer...".

(There are no square brackets.)

Once this is done please fix the build error if possible. If not please ping @mmcky and tell him this is ready to merge.

@mmcky
Copy link
Contributor

mmcky commented Mar 2, 2023

@shlff I have merge in the latest main branch -- it should hopefully fix your cache issue.

@github-actions github-actions bot temporarily deployed to commit March 2, 2023 01:16 Inactive
@github-actions github-actions bot temporarily deployed to commit March 2, 2023 01:26 Inactive
@shlff
Copy link
Member

shlff commented Mar 2, 2023

Many thanks @jstac and @mmcky .

I've made the change in the commit fix.

Now, this PR is ready to merge.

@shlff shlff added the ready label Mar 2, 2023
@jstac
Copy link
Contributor Author

jstac commented Mar 2, 2023

Many thanks @shlff

@jstac jstac merged commit 668fd4c into main Mar 2, 2023
@jstac jstac deleted the ineq-edits branch March 2, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants