Skip to content

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Aug 11, 2025

This PR enables the new enable_RTL to quantecon_book_theme

QuantEcon/quantecon-book-theme#292

@netlify
Copy link

netlify bot commented Aug 11, 2025

Deploy Preview for majestic-griffin-10b166 ready!

Name Link
🔨 Latest commit cb7c222
🔍 Latest deploy log https://app.netlify.com/projects/majestic-griffin-10b166/deploys/68abb6d22cab4500089fd567
😎 Deploy Preview https://deploy-preview-8--majestic-griffin-10b166.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mmcky mmcky requested a review from Copilot August 11, 2025 07:20

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Aug 11, 2025

@github-actions github-actions bot temporarily deployed to pull request August 11, 2025 23:02 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Aug 11, 2025

@Zahra-khanzadeh would you mind to take a look at

https://689a768cc619e080ad706f47--majestic-griffin-10b166.netlify.app/about_py

and let me know if this is how rtl script should be formatted

Also the titles in the lectures are currently appearing in the toc as they are all level 1 headers #. In a document there should be 1 level 1 header # and the rest should be level 2 or 3 etc. (## and ###) for markdown syntax.

https://689a768cc619e080ad706f47--majestic-griffin-10b166.netlify.app/intro.html

@mmcky
Copy link
Contributor Author

mmcky commented Aug 11, 2025

Issues:

  • theme update appears to turn the title bar left-to-right.
Screenshot 2025-08-12 at 9 15 26 am
  • sidebar is on the LEFT
Screenshot 2025-08-12 at 9 16 34 am

@github-actions github-actions bot temporarily deployed to pull request August 12, 2025 00:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 13, 2025 00:59 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Aug 13, 2025

@Zahra-khanzadeh thanks for your feedback.

Here is the latest deployment of the new lecture

https://689be36f80d4199f07262392--majestic-griffin-10b166.netlify.app/python_by_example

Please let me know which elements of the RTL isn't right and we can adjust the theme to cater to them.

For example, should the section number 3.1 be on the LHS or the RHS of the subtitle?

I can be free to Zoom later this week if you want to run through edits / changes. Cheers.

@Zahra-khanzadeh
Copy link
Contributor

Thanks a lot, @mmcky ! 🙌
I was genuinely excited when I saw the result, everything looks absolutely perfect to me, and nothing needs to be changed on your side.

About the earlier points (title bar LTR / sidebar on the left), I don’t consider these issues. This is exactly how most international websites handle RTL mode — for example, the UN website does the same when switching to Persian — so it’s both professional and correct.

The only edits needed are on my side: in a few places I typed some technical terms LTR instead of RTL, and I’ll fix those soon. These are content-related, not theme-related.

Everything looks fantastic, thanks again! 🎉

@mmcky mmcky requested a review from Copilot August 25, 2025 01:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the new enable_RTL feature in the quantecon-book-theme by updating the theme to version 0.9.0 and configuring RTL support in the Sphinx configuration.

  • Update quantecon-book-theme from 0.8.2 to 0.9.0
  • Enable RTL (Right-to-Left) text support by adding enable_rtl: True to the Sphinx configuration
  • Upgrade Python version from 3.12 to 3.13 and Anaconda to 2025.06

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lectures/_config.yml Adds enable_rtl: True configuration to enable RTL text support
environment.yml Updates quantecon-book-theme to 0.9.0 and upgrades Python/Anaconda versions
.github/workflows/ci.yml Updates CI workflow to use Python 3.13

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot temporarily deployed to pull request August 25, 2025 01:11 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Aug 25, 2025

@Zahra-khanzadeh thanks for your patience with this feature. We now have a released version of the quantecon-book-theme that includes support for RTL. This PR enables it for this project.

@mmcky mmcky merged commit aa98b1e into main Aug 25, 2025
6 checks passed
@mmcky mmcky deleted the test-rtl-theme branch August 25, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants