-
-
Notifications
You must be signed in to change notification settings - Fork 0
ENH: test enable_RTL in qe_theme #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for majestic-griffin-10b166 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@Zahra-khanzadeh would you mind to take a look at https://689a768cc619e080ad706f47--majestic-griffin-10b166.netlify.app/about_py and let me know if this is how Also the titles in the lectures are currently appearing in the https://689a768cc619e080ad706f47--majestic-griffin-10b166.netlify.app/intro.html |
|
@Zahra-khanzadeh thanks for your feedback. Here is the latest deployment of the new lecture https://689be36f80d4199f07262392--majestic-griffin-10b166.netlify.app/python_by_example Please let me know which elements of the RTL isn't right and we can adjust the theme to cater to them. For example, should the section number 3.1 be on the LHS or the RHS of the subtitle? I can be free to Zoom later this week if you want to run through edits / changes. Cheers. |
|
Thanks a lot, @mmcky ! 🙌 About the earlier points (title bar LTR / sidebar on the left), I don’t consider these issues. This is exactly how most international websites handle RTL mode — for example, the UN website does the same when switching to Persian — so it’s both professional and correct. The only edits needed are on my side: in a few places I typed some technical terms LTR instead of RTL, and I’ll fix those soon. These are content-related, not theme-related. Everything looks fantastic, thanks again! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the new enable_RTL feature in the quantecon-book-theme by updating the theme to version 0.9.0 and configuring RTL support in the Sphinx configuration.
- Update quantecon-book-theme from 0.8.2 to 0.9.0
- Enable RTL (Right-to-Left) text support by adding
enable_rtl: Trueto the Sphinx configuration - Upgrade Python version from 3.12 to 3.13 and Anaconda to 2025.06
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lectures/_config.yml | Adds enable_rtl: True configuration to enable RTL text support |
| environment.yml | Updates quantecon-book-theme to 0.9.0 and upgrades Python/Anaconda versions |
| .github/workflows/ci.yml | Updates CI workflow to use Python 3.13 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@Zahra-khanzadeh thanks for your patience with this feature. We now have a released version of the |


This PR enables the new
enable_RTLtoquantecon_book_themeQuantEcon/quantecon-book-theme#292
rtldiv so we should remove thisquantecon-book-theme=0.9.0