Add missing font file and GPU admonition for build#23
Merged
Conversation
- Add SourceHanSerifSC-SemiBold.otf for Chinese character rendering in matplotlib plots (from lecture-intro.zh-cn) - Add lectures/_admonition/gpu.md (translated GPU warning for jax_intro and numpy_vs_numba_vs_jax)
There was a problem hiding this comment.
Pull request overview
Adds missing lecture build assets to fix cache-workflow build failures caused by translated lectures referencing files that weren’t committed.
Changes:
- Add the missing CJK matplotlib font asset (
SourceHanSerifSC-SemiBold.otf) referenced across multiple lectures. - Add the missing GPU warning admonition include (
lectures/_admonition/gpu.md) used by JAX-related lectures.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lectures/_fonts/SourceHanSerifSC-SemiBold.otf |
Adds the missing Source Han Serif SC font file required by matplotlib font-loading in several translated lectures. |
lectures/_admonition/gpu.md |
Adds the translated GPU warning admonition included by JAX-related lecture pages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes build failures from the cache workflow by adding two missing files.
Changes
lectures/_fonts/SourceHanSerifSC-SemiBold.otf— Chinese font file (Source Han Serif SC) required by 18 lecture files for rendering CJK characters in matplotlib plots. Sourced from lecture-intro.zh-cn.lectures/_admonition/gpu.md— Translated GPU warning admonition included byjax_intro.mdandnumpy_vs_numba_vs_jax.md. Matches the upstreamlecture-python-programmingfile.Context
The translation process added
# i18nfont-loading code to all lectures using matplotlib, referencing_fonts/SourceHanSerifSC-SemiBold.otf, but the font file was never committed. Similarly,_admonition/gpu.mdexists in the upstream repo but was not included in the translation repo.