Skip to content

Lecture 4 and 5: Integrating "More Functions" Section into Chapter 4#205

Merged
jstac merged 5 commits intomainfrom
lec-review-more-functions
Aug 19, 2022
Merged

Lecture 4 and 5: Integrating "More Functions" Section into Chapter 4#205
jstac merged 5 commits intomainfrom
lec-review-more-functions

Conversation

@HumphreyYang
Copy link
Copy Markdown
Member

Hi @jstac,

I integrated the "More Functions" section in Chapter 5 into subsections in Chapter 4. Here is what I have done in this PR:

  1. Splitting up contents in subsections of More Functions into different sections in Chapter 4;
  2. Created a new section called Code Style and Documentation that includes PEP8 and docstrings.

I am planning to put the namespace section as a separate section before the Code Style and Documentation section in Chapter 5, and I will open up a separate PR for that section after this PR is merged.

Could you please kindly review the changes in this PR, and inform me if there is anything I need to add?

Thank you

@HumphreyYang HumphreyYang changed the title Lecture 4 and 5: Integrating More Functions Section into Chapter 4 Lecture 4 and 5: Integrating "More Functions" Section into Chapter 4 Aug 19, 2022
@github-actions github-actions Bot temporarily deployed to commit August 19, 2022 06:19 Inactive
@jstac
Copy link
Copy Markdown
Contributor

jstac commented Aug 19, 2022

Nice work @HumphreyYang , many thanks. No changes required. Merging.

@jstac jstac merged commit 1742a3e into main Aug 19, 2022
@jstac jstac deleted the lec-review-more-functions branch August 19, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants