Conversation
Contributor
|
thanks @HumphreyYang I think this is a good addition. |
Contributor
|
@jstac if you approve then I'll merge. |
Contributor
|
Thanks @HumphreyYang , nice work. My only comment is that in #230 I suggested "adding a second part to the exercise where 4 is replaced by a large number and the reader is asked to time a for loop against the broadcast implementation." In other words, the reader first replicates on a small example to make sure that they are getting the same result, and then tests the two versions on a larger example to investigate timing. Do you think this is worthwhile? |
Member
Author
|
Hi @jstac, I have added back the sample example. Could you have another look at the newest deployment? Many thanks. |
Contributor
|
Perfect. Thanks @HumphreyYang! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mmcky,
This resolves #230. Could you please kindly review this PR and let me know if there is anything I could change?
Many thanks