Conversation
mmcky
approved these changes
Nov 2, 2022
Contributor
mmcky
left a comment
mmcky
left a comment
There was a problem hiding this comment.
Love your work. Thanks @HumphreyYang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mmcky,
This PR resolves #246. The issue is quite trivial and hidden in the
forloop. It seems thatyfinancechanged to date + time index and the Japanese market has different closing times from the US market, which leads to inconsistency in the index.After updating the index to only dates, the issue is resolved.
Could you please kindly review the change and merge it if it looks good to you?
Many thanks!