Conversation
|
Hi @mmcky, Could you have a quick review on this PR to see where I should further improve? Many thanks in advance! |
|
@HumphreyYang I have updated the |
Many thanks @mmcky, the build runs much faster! I did not see any notable issues in the build. |
mmcky
left a comment
There was a problem hiding this comment.
@HumphreyYang thanks for putting this together.
I am not sure that we should talk much about arbitrary functions *args and **kwargs as I don't think this is a great fit for the intended audience of this lecture. What do you think?
|
Hi @mmcky, Thanks for your spot-on feedback last time. I have pushed a simplified version of the PR. I made some choices during the process:
I think this exercise is a good one to help readers to distinguish I was curious about what is your opinions on the current version and the compromises I have made. Many thanks in advance. Have a lovely Christmas and New Year! 🎄 |
|
thanks @HumphreyYang I have taken another look at the simplified version. I am still wondering if this is @jstac do you have good example? I imagine the most common |
lectures/python_advanced_features.md
Outdated
| # Set up the frame and subplots | ||
| fig, ax = plt.subplots(2, 1) | ||
| plt.subplots_adjust(hspace=0.7) | ||
| plt.rcParams["figure.figsize"] = (10, 6) |
There was a problem hiding this comment.
Do we need line 356? This is usually at the top of each lecture.
|
Hi all, I think this is maybe a fraction long, given that we work hard to keep discussion very short, but nicely written and a good example. I recommend merging conditional on addressing the minor comment above. Nice work @HumphreyYang . |
|
thanks @HumphreyYang and @jstac will merge this in now. |
This PR resolves #257 by adding a section on the use of
*.