Skip to content

FIX: GA for latest qe-theme#273

Merged
mmcky merged 1 commit intomainfrom
google-analytics
Apr 14, 2023
Merged

FIX: GA for latest qe-theme#273
mmcky merged 1 commit intomainfrom
google-analytics

Conversation

@AakashGfude
Copy link
Copy Markdown
Member

updating the config variable for google analytics

@github-actions
Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to pull request April 13, 2023 03:27 Inactive
Comment thread lectures/_config.yml
og_logo_url: https://assets.quantecon.org/img/qe-og-logo.png
description: This website presents a set of lectures on python programming for economics, designed and written by Thomas J. Sargent and John Stachurski.
keywords: Python, QuantEcon, Quantitative Economics, Economics, Sloan, Alfred P. Sloan Foundation, Tom J. Sargent, John Stachurski
analytics:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @AakashGfude is this specific to quantecon-book-theme as sphinx-book-theme moved it to the top level?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmcky it is because of pydata-sphinx-theme. From what I read in their latest code: https://github.com/pydata/pydata-sphinx-theme/blob/main/docs/user_guide/analytics.rst . Did sbt do that in their code?
Locally, the ga code is getting included when I do this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting -- ok thanks @AakashGfude

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Apr 14, 2023

@DrDrij I will merge this as a test case using lecture-programming and we can see if the correct html is included for the G4 codes.

@mmcky mmcky merged commit 1980c36 into main Apr 14, 2023
@mmcky mmcky deleted the google-analytics branch April 16, 2023 23:37
@DrDrij
Copy link
Copy Markdown
Member

DrDrij commented Apr 18, 2023

@DrDrij I will merge this as a test case using lecture-programming and we can see if the correct html is included for the G4 codes.

Test case looks to work well @mmcky. I've setup a GA4 code PR here: #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants