Conversation
|
Hi @Smit-create @chappiewuzefan and @HengchengZhang It would be greatly appreciated if you were available to have a quick review of this lecture : ) Many thanks in advance. |
Smit-create
left a comment
Smit-create
left a comment
There was a problem hiding this comment.
This looks nice @HumphreyYang. I left some small comments. Thank you!
Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in>
Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in>
HengchengZhang
left a comment
HengchengZhang
left a comment
There was a problem hiding this comment.
Many thanks @HumphreyYang for this lecture, I've not much familiar with simpy package thus I only made some general changes.
Hi @mmcky, Many thanks for your comments. I have been working on another project lately, so this is still a writing-in-progress lecture. I will look into your comments and make the changes you suggested today : ) |
Co-authored-by: zhc <79777246+HengchengZhang@users.noreply.github.com>
mmcky
left a comment
mmcky
left a comment
There was a problem hiding this comment.
Thanks Humphrey -- just added a few additional comments.
Co-authored-by: mmcky <mmcky@users.noreply.github.com>
|
Great work @HumphreyYang and @chappiewuzefan , thanks @mmcky for the review. The lecture is excellent but the equalizing differences material should not be in there. It's too dense and complex. I thought we agreed to shift it to the equalizing differences lecture in the intro lecture series. Please see also my minor comments above. |
Many thanks @jstac for the review. I will update these suggestions. I thought the plan was to have your opinion before migrating the content. I will put together a PR on the intro series side to integrate this application into the equalizing differences lecture. I will also move the content in exercise 3 on pure exchange economy to the main text. |
|
Thanks @HumphreyYang , you are right. I appreciate it. Please go ahead. |
|
Thanks @jstac and @HumphreyYang I will merge and make this live and then seek comment from |
Hi @mmcky, I have removed the content on equalizing differences model and am now putting together a PR in the intro series. I will put SymPy as a separate section in that lecture and seek suggestions from you. Many thanks. |
|
thanks @HumphreyYang I will merge this now. |
* add sympy * update sympy exercise * Update lectures/sympy.md Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in> * Update lectures/sympy.md Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in> * update stats * remove user expressions * Update lectures/sympy.md Co-authored-by: zhc <79777246+HengchengZhang@users.noreply.github.com> * try build without scaling headers * draft of application section * update exercise again * proofread * proofread changes * Update lectures/sympy.md Co-authored-by: mmcky <mmcky@users.noreply.github.com> * update two sentences * integrate feedbacks --------- Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in> Co-authored-by: zhc <79777246+HengchengZhang@users.noreply.github.com> Co-authored-by: mmcky <mmcky@users.noreply.github.com>
* lecture on devEnvs added lecture on working with python scripts and workspaces * Update workspace.md * implemented recommendations and corrections * Update workspace.md * Fix broken links * suggestions * Update workspace.md * add screenshots * update lectures Workspaces - implement suggestions and corrections getting stared - add content on debugging * implement updates - getting_started.md: add content on real time collaboration - workspace.md: correct and revise content * Update anaconda env (#290) * Remove MatplotlibDeprecationWarning in Matplotlib Lecture (#289) * remove MatplotlibDeprecationWarning * update false-positive link * MAINT: re-install requests to see if that fixes the malformed requests file * Binder hub url removal #281 * Migrate Sympy Lecture from the Intro Series (#284) * add sympy * update sympy exercise * Update lectures/sympy.md Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in> * Update lectures/sympy.md Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in> * update stats * remove user expressions * Update lectures/sympy.md Co-authored-by: zhc <79777246+HengchengZhang@users.noreply.github.com> * try build without scaling headers * draft of application section * update exercise again * proofread * proofread changes * Update lectures/sympy.md Co-authored-by: mmcky <mmcky@users.noreply.github.com> * update two sentences * integrate feedbacks --------- Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in> Co-authored-by: zhc <79777246+HengchengZhang@users.noreply.github.com> Co-authored-by: mmcky <mmcky@users.noreply.github.com> * MAINT: Migrate from EC2 backend to GA backend (#285) * MAINT: Migrate from EC2 backend to GA backend * update machine details to github actions * FIX: fix requests issue with docutils incompatibility (#287) * FIX: fix requests issue with docutils incompatibility * Fix broken links --------- Co-authored-by: hengchengzhang <hengcheng.zhang@outlook.com> * update suggestions * mmcky edits --------- Co-authored-by: hengchengzhang <hengcheng.zhang@outlook.com> Co-authored-by: mmcky <mmcky@users.noreply.github.com> Co-authored-by: Humphrey Yang <39026988+HumphreyYang@users.noreply.github.com> Co-authored-by: mmcky <mamckay@gmail.com> Co-authored-by: AakashGC <aakashguptachoudhury@gmail.com> Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in> Co-authored-by: zhc <79777246+HengchengZhang@users.noreply.github.com>
6 participants
Migrate from QuantEcon/lecture-python-intro#272