Skip to content

Split first OOP / names / namespaces lecture in two#307

Merged
jstac merged 10 commits intomainfrom
oop_names_edits
Mar 3, 2024
Merged

Split first OOP / names / namespaces lecture in two#307
jstac merged 10 commits intomainfrom
oop_names_edits

Conversation

@jstac
Copy link
Copy Markdown
Contributor

@jstac jstac commented Mar 1, 2024

This PR refactors the Object Oriented Programming lecture

@jstac
Copy link
Copy Markdown
Contributor Author

jstac commented Mar 1, 2024

@mmcky when you have a moment would you mind to look into this and tidy up?

@mmcky mmcky self-requested a review March 1, 2024 03:11
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

Comment thread lectures/oop_intro.md Outdated

* The local namespace for the function is created.
* Local names `x` and `a` are bound, so that the local namespace becomes `{'x': 10, 'a': 1}`.
* Note that the global `a` was not affected by the local `a`.
Copy link
Copy Markdown
Contributor

@mmcky mmcky Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac should this be indented? I think it belongs at the root level.

@github-actions github-actions Bot temporarily deployed to pull request March 1, 2024 03:51 Inactive
Copy link
Copy Markdown
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac I noticed that the sections in oop_intro

  • namespaces
  • Viewing namespaces
  • Interactive Sessions
  • The global namespace
  • Local Namespaces
  • The _builtins_ namespace
  • Name Resolution

are pretty similar to names -- is this intention or should they be removed and make reference to the earlier lecture?

  • I propose we add a seealso admonition in ### {index}`Mutable <single: Mutable>` versus {index}`Immutable <single: Immutable>` parameters back to the names section on this topic.

@jstac
Copy link
Copy Markdown
Contributor Author

jstac commented Mar 1, 2024

Sorry @mmcky , I made a complete mess of this, doing it in a rush.

I've fixed the duplicates and the indent.

@jstac
Copy link
Copy Markdown
Contributor Author

jstac commented Mar 1, 2024

Will this spit out a new netlify version after my latest pushes are built?

@github-actions github-actions Bot temporarily deployed to pull request March 1, 2024 05:16 Inactive
@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Mar 1, 2024

Thanks @jstac -- will review again tomorrow.

Netlify has the latest.

Should we switch the order for OOP 1: Names and Namespaces and OOP 1: Objects and Methods?

Screenshot 2024-03-01 at 9 48 48 pm

@jstac
Copy link
Copy Markdown
Contributor Author

jstac commented Mar 1, 2024

Hi @mmcky , thanks for picking that up. I've fixed it. Could you please look into why the build is failing?

@github-actions github-actions Bot temporarily deployed to pull request March 1, 2024 21:51 Inactive
@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Mar 1, 2024

thanks @jstac this is now building and the preview is available here https://65e24dccd5105e2d2c5da1dc--epic-agnesi-957267.netlify.app/intro.html

I will try and proof read later today or tomorrow morning.

@mmcky mmcky self-requested a review March 1, 2024 22:11
Comment thread lectures/oop_intro.md Outdated

In Python, it is common for users to build custom objects --- we discuss how to
do this [later](python_oop).
do this {doc}`lecture <python_oop>`.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmcky Thanks for trying to fix but the sentence no longer makes sense.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jstac -- apologies many of these are in a later lecture . Thanks for catching this.

@github-actions github-actions Bot temporarily deployed to pull request March 3, 2024 08:53 Inactive
@jstac jstac merged commit a60d221 into main Mar 3, 2024
@jstac jstac deleted the oop_names_edits branch March 3, 2024 18:20
@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Mar 3, 2024

@jstac I will do a proof-read of the two lectures today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants