Skip to content

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Oct 18, 2021

This PR updates

  • anaconda
  • jupyter-book
  • quantecon-book-theme
  • sphinx-exercise
  • sphinx-tojupyter

@github-actions github-actions bot temporarily deployed to commit October 18, 2021 04:35 Inactive
@github-actions github-actions bot temporarily deployed to commit October 18, 2021 04:39 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Oct 18, 2021

@shlff would you have 10 minutes to cast an eye over the generated preview above and let me know if you spot any issues (as a double check). This is a big upgrade to the software so it would be great to get a second opinion on:

  • html
  • download ipynb
  • download pdf

@mmcky
Copy link
Contributor Author

mmcky commented Oct 18, 2021

  • check arg\\max and arg\\min rendering in math (html)

@github-actions github-actions bot temporarily deployed to commit October 18, 2021 05:19 Inactive
@github-actions github-actions bot temporarily deployed to commit November 19, 2021 04:17 Inactive
@github-actions github-actions bot temporarily deployed to commit November 19, 2021 04:42 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Nov 19, 2021

hey @shlff can you let me know if you're planning to review this PR? No worries if you don't have the time. I'll set some time aside next week to review so it can be merged.

@shlff
Copy link
Member

shlff commented Nov 19, 2021

Thanks for reminding me of this @mmcky . Actually I reviewed this PR last month but I forgot to update my reports here. I would take time to recall the issues I find and report them to you by next Tuesday (23nd Nov.).

@github-actions github-actions bot temporarily deployed to commit November 21, 2021 23:55 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Nov 21, 2021

@shlff I just updated anaconda to the 2021.11 from 2021.05 (which was causing some issues). Hopefully the 2021.11 will be more stable. Looks god so far from my review.

@mmcky
Copy link
Contributor Author

mmcky commented Nov 23, 2021

From my review this morning I think this is looking pretty complete.

@github-actions github-actions bot temporarily deployed to commit November 23, 2021 23:00 Inactive
@github-actions github-actions bot temporarily deployed to commit November 23, 2021 23:16 Inactive
@github-actions github-actions bot temporarily deployed to commit November 23, 2021 23:33 Inactive
@github-actions github-actions bot temporarily deployed to commit November 23, 2021 23:50 Inactive
@github-actions github-actions bot temporarily deployed to commit November 24, 2021 00:10 Inactive
@github-actions github-actions bot temporarily deployed to commit November 24, 2021 00:25 Inactive
@github-actions github-actions bot temporarily deployed to commit November 24, 2021 00:40 Inactive
@github-actions github-actions bot temporarily deployed to commit November 24, 2021 01:06 Inactive
@github-actions github-actions bot temporarily deployed to commit November 24, 2021 01:30 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Nov 24, 2021

@shlff I am going to merge this so if there are any bugs that you come across let me know and we can issue a fix.

@mmcky mmcky merged commit 2dac229 into main Nov 24, 2021
@mmcky mmcky deleted the upgrade-software branch November 24, 2021 01:33
@shlff
Copy link
Member

shlff commented Nov 24, 2021

Thanks @mmcky . I quickly went through the HTML and download pdf of the lectures quickly and didn't find any big issues. They look good to me.

I have been reading the HTML and ipynb files of the lectures one by one carefully and I will report in the issue tracker if I spotted any issue.

@mmcky
Copy link
Contributor Author

mmcky commented Nov 24, 2021

thanks for the update @shlff that gives me confidence :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants