Enhance McCall separation model: Add full solution before simplification #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re simplification This commit improves the pedagogical flow of the job search lecture by: - Introducing a direct solution using both Bellman equations (v_u and v_e) - Computing the reservation wage from the full model solution - Presenting the simplifying transformation as a more efficient approach - Verifying both methods produce identical results (difference < 1e-6) - Fixing several bugs in the new code sections The enhanced structure helps students understand the model fundamentals before learning the computational optimization. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
@mmcky Could you look at this please? |
|
📖 Netlify Preview Ready! Preview URL: https://pr-697--sunny-cactus-210e3e.netlify.app (c3d4fc2) 📚 Changed Lecture Pages: mccall_model_with_separation |
Contributor
Author
|
Hmmm, seems it's all good now. Did you tweak something @mmcky ? Merging. |
Contributor
|
I only re-ran the workflow. Looks like pip rejected the http request. |
Contributor
Author
|
Roger that. Thanks @mmcky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the pedagogical structure of the McCall job search model with separation lecture by introducing a complete solution using both Bellman equations before presenting the computational simplification.
Changes
New Content
Full model solution section (lines 233-388): Implements direct iteration on both value functions
v_uandv_eT_uandT_eoperators implementing the Bellman updatessolve_full_model()function for simultaneous iterationw_bar_full = 11.8644Method verification (lines 578-587): Demonstrates equivalence of both approaches
Improved Structure
Bug Fixes
T_eoperatorTesting
✅ All code runs without errors (verified via
jupytextconversion and execution)✅ Both solution methods produce identical reservation wages
✅ All plots render correctly
Pedagogical Impact
Students now:
🤖 Generated with Claude Code