Skip to content

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Nov 14, 2025

This PR upgrades sphinx-tojupyter from version 0.3.1 to 0.4.0 in the environment.yml file.

Changes:

  • Updated sphinx-tojupyter dependency from 0.3.1 to 0.4.0

Testing:
The CI workflow will validate that the build completes successfully with the new version.

@mmcky
Copy link
Contributor Author

mmcky commented Nov 14, 2025

@HumphreyYang once this builds would you mind being a second set of eyes on:

  • html for McCall model with separation (lecture with glue)
  • download the notebook of that lecture and check locally for the included glue figures
  • verify the latex for that lecture with included glue figures
  • collab will only work once we publish and updated notebooks are pushed to notebooks repo

@HumphreyYang
Copy link
Member

@HumphreyYang once this builds would you mind being a second set of eyes on:

Sure I will update once I tick off all the boxes.

@github-actions
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-702--sunny-cactus-210e3e.netlify.app (e979d50)

@HumphreyYang
Copy link
Member

  • verify the latex for that lecture with included glue figures

Hi @mmcky the first two items look great! For the latex, I think the figure is not fixed at the position.

We might need to tag is using [h!]?
image

@mmcky
Copy link
Contributor Author

mmcky commented Nov 14, 2025

thanks @HumphreyYang that will need to be addressed via _config.yml or sphinx-jupyterbook-latex -- so I think we can merge this.

@HumphreyYang
Copy link
Member

Many thanks @mmcky, I agree!

@mmcky mmcky merged commit f572fcf into main Nov 14, 2025
1 check passed
@mmcky mmcky deleted the upgrade-sphinx-tojupyter-0.4.0 branch November 14, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants