Fix notation conflict: change volatility parameter from s to ν #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the shock scale parameter from 's' to 'ν' (Greek letter nu) to resolve the naming conflict with savings (s = x - c). This makes the code more readable and consistent with mathematical notation conventions. Changes: - Updated mathematical notation in text to use \nu instead of s - Changed Model NamedTuple field from 's' to 'ν' - Updated create_model function parameter from 's' to 'ν' - Modified shock calculation to use ν - Simplified Model instantiation to use positional arguments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
This change improves code clarity by eliminating the confusing dual use of the variable 's'. Now 's' is used exclusively for savings (s = x - c), and 'ν' (nu) is used for the volatility parameter in the shock distribution. The Greek letter ν is a natural choice that aligns with common mathematical conventions for volatility parameters. |
|
📖 Netlify Preview Ready! Preview URL: https://pr-728--sunny-cactus-210e3e.netlify.app (5bbd1d4) 📚 Changed Lecture Pages: cake_eating_stochastic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a notation conflict in the stochastic cake eating lecture where the variable
swas being used for both:s = x - cξ := exp(μ + s ζ)The volatility parameter has been changed to
ν(Greek letter nu) throughout both the mathematical text and Python code.Changes
sto\nuModelNamedTuple field froms: floattoν: floatcreate_modelfunction parameter fromstoνν:shocks = np.exp(μ + ν * np.random.randn(shock_size))Modelinstantiation from keyword arguments to positional arguments for cleaner codeTest plan
🤖 Generated with Claude Code