upgrade: @myst-theme 1.1.2 → 1.3.0 (latest upstream) + Node 24 toolchain#59
Merged
Conversation
…hain Bring the theme up to date with the upstream ecosystem ahead of 2.0.0. - Bump @myst-theme/* + myst-to-react to ^1.3.0 and myst-common/myst-config to ^1.9.5 — matches the current upstream book-theme (deployed at 1.3.0). Still React 18; no peer/ERESOLVE conflicts. - Move dev/CI/release toolchain to Node 24 (.nvmrc, ci.yml, release.yml), matching upstream's build. Raise the engines floor >=18 -> >=20 (drops EOL Node 18) while keeping a lenient consumer floor like upstream. - Validated on Node 24: npm ci + npm run compile + npm run prod:build all pass (also green on Node 18). The Node 26 esbuild deadlock does not occur on Node 24. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates this theme’s upstream MyST dependencies and aligns the project’s development/CI toolchain with a newer Node runtime in preparation for the upcoming 2.0.0 work.
Changes:
- Bump
@myst-theme/*andmyst-to-reactto^1.3.0, andmyst-common/myst-configto^1.9.5, with corresponding lockfile updates. - Raise the Node engine floor to
>=20and move local/CI/release Node versions to 24 (.nvmrc, CI, release workflow). - Update the changelog entry describing the dependency/toolchain upgrades.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Updates MyST package versions and raises Node engine floor to >=20; keeps packageManager pinned to npm 8.10.0. |
package-lock.json |
Updates resolved dependency graph for the bumped packages; contains some metadata that should be kept consistent with package.json engines/tooling. |
CHANGELOG.md |
Revises the existing entry to reflect the newer MyST versions and Node 24 tooling. |
.nvmrc |
Pins local Node version to 24. |
.github/workflows/ci.yml |
Runs CI on Node 24. |
.github/workflows/release.yml |
Runs release workflow on Node 24. |
.claude/scheduled_tasks.lock |
Adds a machine/session-specific lockfile (likely unintended to commit). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove accidentally-committed .claude/scheduled_tasks.lock (git add -A swept in a Claude session lockfile); gitignore .claude session/local state. - Drop stale `packageManager: npm@8.10.0` — inconsistent with Node 24 (ships npm 11) and lockfileVersion 3; not enforced here. - ci.yml + release.yml: `npm install` -> `npm ci` for reproducible installs against the committed lockfile. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the theme up to date with the upstream ecosystem ahead of 2.0.0.
Changes
@myst-theme/*+myst-to-react→^1.3.0,myst-common/myst-config→^1.9.5— matches the current upstreambook-theme(its deployed bundle is already on 1.3.0). Still React 18; no peer/ERESOLVE conflicts..nvmrc,ci.yml,release.yml), mirroring upstream's build. Engines floor>=18→>=20(drops EOL Node 18; upstream keeps a lenient consumer floor, so we don't force consumers to 24).npm ci(reproducible installs against the committed lockfile); dropped the stalepackageManager: npm@8.10.0pin.Validation
npm ci+npm run compile+npm run prod:buildall green on Node 24 (the supported floor is now Node>=20). The Node 26 esbuild deadlock does not occur on Node 24, so Remix v1.19 builds fine there.Notes