Skip to content

Fix crypto profile i18n alias#30

Merged
Pigbibi merged 1 commit into
mainfrom
codex/fix-crypto-i18n-namespace
Jun 4, 2026
Merged

Fix crypto profile i18n alias#30
Pigbibi merged 1 commit into
mainfrom
codex/fix-crypto-i18n-namespace

Conversation

@Pigbibi
Copy link
Copy Markdown
Contributor

@Pigbibi Pigbibi commented Jun 4, 2026

Summary

  • keep crypto_leader_rotation as a compatibility alias for crypto_live_pool_rotation
  • expose manifest aliases and bump crypto-strategies to 0.4.8
  • localize the Chinese README strategy name

Validation

  • python -m ruff check src/crypto_strategies/catalog.py src/crypto_strategies/manifests/init.py src/crypto_strategies/init.py tests/test_catalog.py tests/test_contract_governance.py
  • PYTHONPATH=src:../QuantPlatformKit/src python -m unittest tests.test_catalog tests.test_contract_governance

@Pigbibi Pigbibi merged commit 6580ab4 into main Jun 4, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/fix-crypto-i18n-namespace branch June 4, 2026 05:12
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92d5226e55

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

domain="crypto",
display_name="Crypto Live Pool Rotation",
description="Trend-following crypto rotation with staged entries, degradation controls, and cash parking.",
aliases=("crypto_leader_rotation",),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Resolve manifest aliases before lookup

Declaring crypto_leader_rotation as a manifest alias advertises it as usable metadata, but get_strategy_manifest() still indexes MANIFESTS only by canonical profile, so callers that keep the legacy profile in config and ask for its manifest get a KeyError even though catalog and runtime-adapter lookups now resolve the alias. Please either add alias entries to MANIFESTS or route this lookup through the same catalog alias resolver so manifest compatibility matches the rest of the package.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant