Skip to content

Update US equity strategies dependency#103

Merged
Pigbibi merged 1 commit into
mainfrom
codex/rename-nasdaq-sp500-smart-dca-20260619
Jun 18, 2026
Merged

Update US equity strategies dependency#103
Pigbibi merged 1 commit into
mainfrom
codex/rename-nasdaq-sp500-smart-dca-20260619

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update UsEquityStrategies to 22689494e922a8b18349562edcc6389d2faaed8f so platform runtime sees the clarified Nasdaq 100 / S&P 500 Smart DCA name

Tests

  • git diff --check
  • rg old strategy label / old SHA scan

@Pigbibi Pigbibi merged commit 1078ec5 into main Jun 18, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/rename-nasdaq-sp500-smart-dca-20260619 branch June 18, 2026 16:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bee81a99c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread requirements.txt
firstrade==0.0.39
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@b846c9d777a450e95d23c264853997d671f47dd9
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@f92301b329ab5054ec5ed6fb8ce043b48ff18a0e
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@22689494e922a8b18349562edcc6389d2faaed8f

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the editable-install dependency pin too

This bumps only requirements.txt, but the documented quick start uses python -m pip install -e ., which resolves dependencies from pyproject.toml; that file still pins us-equity-strategies to d08492ea... instead of this new 22689494.... Anyone installing the platform as a package (including local devs following README.md:41 or build flows that use project metadata) will still run against the old strategy package and won't see the clarified Nasdaq 100 / S&P 500 Smart DCA name this change is meant to deliver.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant