[codex] Route runtime errors to main bot#71
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c11685f36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| CRISIS_ALERT_TELEGRAM_PARSE_MODE: ${{ vars.CRISIS_ALERT_TELEGRAM_PARSE_MODE }} | ||
| CRISIS_ALERT_TELEGRAM_DISABLE_WEB_PAGE_PREVIEW: ${{ vars.CRISIS_ALERT_TELEGRAM_DISABLE_WEB_PAGE_PREVIEW }} | ||
| CRISIS_ALERT_TELEGRAM_BODY_MAX_CHARS: ${{ vars.CRISIS_ALERT_TELEGRAM_BODY_MAX_CHARS }} | ||
| STRATEGY_PLUGIN_ALERT_CHANNELS: ${{ vars.STRATEGY_PLUGIN_ALERT_CHANNELS }} |
There was a problem hiding this comment.
Preserve old alert vars during the rename
When this workflow first runs after the rename, installations that still have the existing CRISIS_ALERT_* GitHub variables/secrets but have not manually created the new STRATEGY_PLUGIN_ALERT_* names will resolve these new env entries as empty; the sync step then removes the old CRISIS_ALERT_* Cloud Run keys, and runtime_config_support.py only reads the new names, so strategy plugin alert recipients/tokens are silently cleared. Please either fall back to the old variable names while syncing/loading settings or add a migration path before removing the old Cloud Run envs.
Useful? React with 👍 / 👎.
Summary
Validation