[codex] Improve manual review notification cards#16
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a90124fb32
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| f"仲裁:{plugin} = {route};" | ||
| f"{'crisis/macro 未 veto' if not vetoes else '存在 veto:' + _message_join(vetoes, locale)}。" |
There was a problem hiding this comment.
Avoid claiming veto checks ran for standalone plugins
When this formatter is used for standalone taco_rebound_shadow or panic_reversal_shadow runs, there is no market-regime arbiter or position_control.vetoes, so an empty vetoes tuple means “not checked”, not “crisis/macro did not veto”. The new manual-review card therefore gives a false risk-control assurance for direct notification mounts; only market_regime_control payloads can make this claim.
Useful? React with 👍 / 👎.
Summary
Historical checks
Validation
Runtime boundary
No trading or allocation behavior changes. The cards explicitly say notify-only, no broker orders, and no allocation mutation.