Skip to content

Improve vetoed opportunity notifications#17

Merged
Pigbibi merged 1 commit into
mainfrom
improve-vetoed-opportunity-notifications
Jun 6, 2026
Merged

Improve vetoed opportunity notifications#17
Pigbibi merged 1 commit into
mainfrom
improve-vetoed-opportunity-notifications

Conversation

@Pigbibi
Copy link
Copy Markdown
Contributor

@Pigbibi Pigbibi commented Jun 6, 2026

Summary

  • surface vetoed TACO/panic opportunities in market_regime_control notifications without changing position-control permissions
  • rewrite manual-review notifications around situation and suggested action, hiding internal route/veto/governance codes from user-facing copy
  • document plugin vs strategy-side position-control permission boundaries

Verification

  • timeout 120s env PYTHONPATH=/home/ubuntu/Projects/QuantStrategyPlugins/src uv run --no-project --with pandas --with pytest pytest -q
  • timeout 120s uv run --no-project --with ruff ruff check .

@Pigbibi Pigbibi merged commit 5b0b36f into main Jun 6, 2026
1 check passed
@Pigbibi Pigbibi deleted the improve-vetoed-opportunity-notifications branch June 6, 2026 20:23
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9efe268835

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if _as_bool(plugin_config.get("panic_reversal_enabled"), default=False):
components["panic_reversal"] = _build_panic_reversal_payload(price_history, plugin_config)
panic_config = dict(plugin_config)
panic_config.setdefault("suppress_when_price_crisis_guard_active", False)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Let TACO reach the arbiter for veto notices

This only disables the price-crisis guard for the panic-reversal component. The TACO component above is still built from the original plugin_config, while build_taco_rebound_shadow_signal defaults suppress_when_price_crisis_guard_active=True; on a crisis/macro de-risking day with an otherwise valid TACO rebound, TACO is downgraded to watch/no_action before build_market_regime_control_signal can add it to notification.vetoed_opportunities. That means the new vetoed-opportunity notification path still won't surface vetoed TACO opportunities in the same guarded contexts where panic reversal now works.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant