Improve vetoed opportunity notifications#17
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9efe268835
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if _as_bool(plugin_config.get("panic_reversal_enabled"), default=False): | ||
| components["panic_reversal"] = _build_panic_reversal_payload(price_history, plugin_config) | ||
| panic_config = dict(plugin_config) | ||
| panic_config.setdefault("suppress_when_price_crisis_guard_active", False) |
There was a problem hiding this comment.
Let TACO reach the arbiter for veto notices
This only disables the price-crisis guard for the panic-reversal component. The TACO component above is still built from the original plugin_config, while build_taco_rebound_shadow_signal defaults suppress_when_price_crisis_guard_active=True; on a crisis/macro de-risking day with an otherwise valid TACO rebound, TACO is downgraded to watch/no_action before build_market_regime_control_signal can add it to notification.vetoed_opportunities. That means the new vetoed-opportunity notification path still won't surface vetoed TACO opportunities in the same guarded contexts where panic reversal now works.
Useful? React with 👍 / 👎.
Summary
Verification