chore: Add dedicated PrimaryKeyError#17
Merged
MariusMerkleQC merged 3 commits intomainfrom Mar 19, 2026
Merged
Conversation
PrimaryKeyError
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 10 +1
Lines 704 707 +3
=========================================
+ Hits 704 707 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a dedicated PrimaryKeyError exception to make primary-key-related failures in diffly easier to catch distinctly from generic ValueErrors (per issue #16).
Changes:
- Introduces
diffly.PrimaryKeyError(defined in a new internal module and re-exported at package level). - Updates
DataFrameComparison/compare_framesprimary key validation and “missing primary key” join checks to raisePrimaryKeyError. - Adjusts affected tests to expect
PrimaryKeyErrorinstead ofValueError.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
diffly/_exceptions.py |
Adds the new PrimaryKeyError exception type. |
diffly/__init__.py |
Re-exports PrimaryKeyError to support from diffly import PrimaryKeyError. |
diffly/comparison.py |
Replaces primary-key-related ValueError raises with PrimaryKeyError. |
tests/test_dataframe_comparison.py |
Updates primary key validation tests to assert PrimaryKeyError. |
tests/test_joined.py |
Updates missing-primary-key join test to assert PrimaryKeyError. |
tests/test_fraction_same.py |
Updates missing-primary-key fraction_same test to assert PrimaryKeyError. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
borchero
reviewed
Mar 19, 2026
EgeKaraismailogluQC
approved these changes
Mar 19, 2026
Collaborator
EgeKaraismailogluQC
left a comment
There was a problem hiding this comment.
Looks good to me!
borchero
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solves #16
Changes
PrimaryKeyErrorexception in a new_exceptions.pyfilePrimaryKeyErroreasily importable:from diffly import PrimaryKeyErrorValueErrorwithPrimaryKeyError