Skip to content

refactor: endPorts arguments#114

Merged
croyzor merged 3 commits intomainfrom
cr/refactor/endports
May 1, 2026
Merged

refactor: endPorts arguments#114
croyzor merged 3 commits intomainfrom
cr/refactor/endports

Conversation

@croyzor
Copy link
Copy Markdown
Collaborator

@croyzor croyzor commented Apr 27, 2026

Use a GADT to infer what functions we call to make ends and ports, rather than passing higher order functions

@croyzor croyzor requested a review from acl-cqc April 27, 2026 12:57
Copy link
Copy Markdown
Collaborator

@acl-cqc acl-cqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nice, thanks!

Comment thread brat/Brat/Checker/Helpers.hs Outdated
endPorts _ _ _ _ stuff R0 = pure ([], stuff)
endPorts node port2End mkPort n (ga, ez) (RPr (p,ty) ro) = do
endPorts _ _ _ stuff R0 = pure ([], stuff)
endPorts node rowPol n (ga, ez) (RPr (p,ty) ro) = do
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just polarity? not e.g. row policy

@croyzor croyzor merged commit 34ed64c into main May 1, 2026
1 check passed
@croyzor croyzor deleted the cr/refactor/endports branch May 1, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants