[refactor] vectorise: take expected mode, make return type explicit#58
Merged
[refactor] vectorise: take expected mode, make return type explicit#58
Conversation
croyzor
reviewed
Nov 26, 2024
brat/Brat/Checker/Helpers.hs
Outdated
| @@ -1,4 +1,4 @@ | |||
| {-# LANGUAGE AllowAmbiguousTypes #-} | |||
| {-# LANGUAGE AllowAmbiguousTypes, ScopedTypeVariables #-} | |||
Collaborator
There was a problem hiding this comment.
Scoped type variables should be on all the time, since it's in GHC2021 in the cabal file
croyzor
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's confusing where responsibility for error handling (expected function, got wrong mode/type) belongs, hence "-- These shouldn't happen" type comments - so, make that clear.
This shortens quite a lot of stuff and makes
getThunksmuch simpler IMHO**, albeit at the cost of a nasty case/match inmkMapFunbecausenextof course completely loses the type of what we've passed in. I argue this "yeuch" is a lot more localised than what we had before, though (and many other places have similar issues withnext!)** This is important, because #41 introduces significant extra complexity here