Skip to content

fix: add missing favicon to the page#28

Merged
maximilianruesch merged 2 commits intomainfrom
mr/fix/favicon
Dec 8, 2025
Merged

fix: add missing favicon to the page#28
maximilianruesch merged 2 commits intomainfrom
mr/fix/favicon

Conversation

@maximilianruesch
Copy link
Copy Markdown
Contributor

Adds a favicon to both the landing page and sphinx docs.

Before:
Screenshot 2025-12-08 at 11 08 20

After:
Screenshot 2025-12-08 at 11 08 37

Note that different repositories for the same overarching docs.quantinuum.com page solve this differently. For example, lambeq uses the same inclusion for the landing page:
https://github.com/Quantinuum/lambeq-docs/blob/40d8dc84cbd2c38f829d5a1270b45c4c43b393ec/landing/src/app/layout.tsx#L37
but references the base themes favicon via a relative import instead of a separate inclusion, based on a certain env variable being set:
https://github.com/Quantinuum/lambeq-docs/blob/40d8dc84cbd2c38f829d5a1270b45c4c43b393ec/docs/conf.py#L92-L98

Perhaps all this should be unified or even handled in the base theme, but for now the simplest solution is just copying the file into the sphinx docs.

@maximilianruesch maximilianruesch changed the title Add missing favicon to the page fix: add missing favicon to the page Dec 8, 2025
@maximilianruesch
Copy link
Copy Markdown
Contributor Author

Failure due to the rename, thus waiting on #30

@CalMacCQ
Copy link
Copy Markdown
Collaborator

CalMacCQ commented Dec 8, 2025

Ah yes this failure seems to be caused by sphinx trying to crosslink to the hugr-py docs with intersphinx here. These are currently down so a warning is emitted. As we are running a strict build which treats warnings as errors then the build fails.

@CalMacCQ CalMacCQ self-requested a review December 8, 2025 13:33
@maximilianruesch maximilianruesch merged commit a872370 into main Dec 8, 2025
3 checks passed
@maximilianruesch maximilianruesch deleted the mr/fix/favicon branch December 8, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants