fix: add missing favicon to the page#28
Merged
maximilianruesch merged 2 commits intomainfrom Dec 8, 2025
Merged
Conversation
Contributor
Author
|
Failure due to the rename, thus waiting on #30 |
Collaborator
|
Ah yes this failure seems to be caused by sphinx trying to crosslink to the hugr-py docs with intersphinx here. These are currently down so a warning is emitted. As we are running a strict build which treats warnings as errors then the build fails. |
CalMacCQ
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a favicon to both the landing page and sphinx docs.
Before:

After:

Note that different repositories for the same overarching
docs.quantinuum.compage solve this differently. For example,lambequses the same inclusion for the landing page:https://github.com/Quantinuum/lambeq-docs/blob/40d8dc84cbd2c38f829d5a1270b45c4c43b393ec/landing/src/app/layout.tsx#L37
but references the base themes favicon via a relative import instead of a separate inclusion, based on a certain env variable being set:
https://github.com/Quantinuum/lambeq-docs/blob/40d8dc84cbd2c38f829d5a1270b45c4c43b393ec/docs/conf.py#L92-L98
Perhaps all this should be unified or even handled in the base theme, but for now the simplest solution is just copying the file into the sphinx docs.