feat(internal): Replace cp use with system call#11
Merged
johnchildren merged 1 commit intomasterfrom Nov 1, 2023
Merged
Conversation
Previously the flags we provided to cp were compiled into the library based on platform, this caused issues when using a different binary to the one provided by the system as flags were sometimes not available. This commit adds a dependency on reflink-copy to enable the same copy on write behavior for postgresql directories but without using the cp binary directly.
johnchildren
force-pushed
the
feat/syscall-reflink
branch
from
d845437 to
4205536
Compare
swhiteCQC
approved these changes
Nov 1, 2023
isobelhooper
approved these changes
Nov 1, 2023
isobelhooper
left a comment
isobelhooper
left a comment
There was a problem hiding this comment.
Clarified with John - because reflink-copy only does COW for files, our code has to do the "copy recursively" logic itself, by creating the target directories and generating all the target file paths.
Looks like it does that well. 👍
|
Also confirmed - in an environment where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the flags we provided to cp were compiled into the library based on platform, this caused issues when using a different binary to the one provided by the system as flags were sometimes not available.
This commit adds a dependency on reflink-copy to enable the same copy on write behavior for postgresql directories but without using the cp binary directly.