Feature: JDK 21 variants#209
Merged
Merged
Conversation
...and bookworm as a new variant option across all other combinations
TODO: Make these less dependent on defaults
Quantisan
approved these changes
Oct 12, 2023
Quantisan
left a comment
Quantisan
left a comment
Owner
There was a problem hiding this comment.
I stepped through your commit one by one. Thanks for staying organized and committing clear, distinct steps! Makes reviewing a breeze.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK this is a bit bigger of a change because in addition to just adding the newly-released JDK 21 upstream image variants, I'm also taking the opportunity to switch the default distro for JDK 21+ images to Debian bookworm (and adding bookworm as a distro option across the board).