Skip to content

Make floating toolbar buttons respond to left handed mode #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

Make floating toolbar buttons respond to left handed mode #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0495d24
Make floating toolbar buttons respond to left handed mode
ecawthorne Jul 16, 2024
83ee38f
Updating changelog (#1208)
QuantumBadger Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/assets/changelog-alpha.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/Alpha 360 (2025-04-21)
Added video frame step controls (thanks to ecawthorne and japanesephundroid)
Make floating toolbar buttons respond to left handed mode (thanks to ecawthorne)

/Alpha 359 (2025-04-20)
Added support for emotes in comment flairs (thanks to bharatknv)
Expand Down
1 change: 1 addition & 0 deletions src/main/assets/changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Show label on crossposts, and add "Go to Crosspost Origin" to post menu (thanks
Added "Mark as Read/Unread" fling action, and optional post menu item (thanks to JoshAusHessen and codeofdusk)
Added preference to prevent posts being marked as read when clicked (thanks to Daniel Ho)
Remove random subreddit feature which is no longer supported by Reddit (thanks to Mark Yu)
Make floating toolbar buttons respond to left handed mode (thanks to ecawthorne)
Codebase improvements: fixed deprecations (thanks to Alexey Rochev)

113/1.24.1
Expand Down
7 changes: 7 additions & 0 deletions src/main/java/org/quantumbadger/redreader/activities/ImageViewActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,13 @@ public void onNotAnImage() {
outerFrame,
false));

if (PrefsUtility.pref_appearance_left_handed()) {
final FrameLayout.LayoutParams toolBarParams =
(FrameLayout.LayoutParams) mFloatingToolbar.getLayoutParams();
toolBarParams.gravity = Gravity.START | Gravity.BOTTOM;
mFloatingToolbar.setLayoutParams(toolBarParams);
}

outerFrame.addView(mFloatingToolbar);

mFloatingToolbar.setVisibility(View.GONE);
Expand Down
8 changes: 8 additions & 0 deletions src/main/java/org/quantumbadger/redreader/fragments/CommentListingFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import android.content.Context;
import android.graphics.Color;
import android.os.Bundle;
import android.view.Gravity;
import android.view.LayoutInflater;
import android.view.Menu;
import android.view.MenuItem;
Expand Down Expand Up @@ -195,6 +196,13 @@ public CommentListingFragment(
mOverlayFrame,
false);

if (PrefsUtility.pref_appearance_left_handed()) {
final FrameLayout.LayoutParams toolBarParams =
(FrameLayout.LayoutParams) mFloatingToolbar.getLayoutParams();
toolBarParams.gravity = Gravity.START | Gravity.BOTTOM;
mFloatingToolbar.setLayoutParams(toolBarParams);
}

// We need a container so that setVisible() doesn't mess with the Z-order
final FrameLayout floatingToolbarContainer = new FrameLayout(context);

Expand Down
Loading