fix: special case pullbacks for fully truncated decompositions#233
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Jutho
reviewed
May 19, 2026
Jutho
reviewed
May 19, 2026
Jutho
reviewed
May 19, 2026
Jutho
reviewed
May 19, 2026
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
Jutho
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought up by @leburgel, the
norm(Base.broadcasted(...), Inf)ends up callingzero(eltype(bc))on the broadcasted expression, and wheneltype(bc) = Anythis ends up throwing.The easiest way around this is to simply catch the "empty" case in the pullbacks themselves, which I think I've now implemented correctly but it might be good to have another look at this.