-
Notifications
You must be signed in to change notification settings - Fork 25
Split off norm-preserving vector retractions #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like somehow codecov is saying the retractions are actually never used. Is this true?
[EDIT] looks like the symmetrization code actually doesn't use the updated retraction, this should probably be fixed :)
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me if tests turn green :)
This splits of the core norm-preserving retraction utilities for vectors as
vector_retractandvector_transport!, and updates the PEPS retractions to broadcast these across the unit cell. The motivation behind this is that I would like to reuse the core retraction tools when optimizing over generic vectors that support VectorInterface (e.g. a singleTensorMapor a plainVector{<:Number}) in settings where the state we're optimizing has additional structure and is therefore not a genericInfinitePEPS.I also noticed that the
utility/diffset.jlfile was still included, but is no longer used anywhere. Since I think we anyway intended to move away from that, I thought it would be appropriate to just remove it.