Skip to content

Conversation

@leburgel
Copy link
Member

@leburgel leburgel commented Mar 18, 2025

This splits of the core norm-preserving retraction utilities for vectors as vector_retract and vector_transport!, and updates the PEPS retractions to broadcast these across the unit cell. The motivation behind this is that I would like to reuse the core retraction tools when optimizing over generic vectors that support VectorInterface (e.g. a single TensorMap or a plain Vector{<:Number}) in settings where the state we're optimizing has additional structure and is therefore not a generic InfinitePEPS.

I also noticed that the utility/diffset.jl file was still included, but is no longer used anywhere. Since I think we anyway intended to move away from that, I thought it would be appropriate to just remove it.

@leburgel leburgel self-assigned this Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/PEPSKit.jl 100.00% <ø> (ø)
src/algorithms/optimization/peps_optimization.jl 96.10% <100.00%> (-0.45%) ⬇️
src/utility/retractions.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leburgel leburgel requested a review from lkdvos March 18, 2025 08:13
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like somehow codecov is saying the retractions are actually never used. Is this true?

[EDIT] looks like the symmetrization code actually doesn't use the updated retraction, this should probably be fixed :)

lkdvos
lkdvos previously approved these changes Mar 18, 2025
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me if tests turn green :)

@leburgel leburgel merged commit 2f7a17a into master Mar 18, 2025
39 checks passed
@leburgel leburgel deleted the lb/vector_retract branch March 18, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants