Skip to content

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Sep 9, 2025

No description provided.

@lkdvos lkdvos requested a review from Yue-Zhengyuan September 9, 2025 23:21
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/contractions/localoperator.jl 94.54% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/algorithms/toolbox.jl 98.38% <100.00%> (+0.08%) ⬆️
src/operators/infinitepepo.jl 64.58% <100.00%> (+2.72%) ⬆️
src/operators/localoperator.jl 89.09% <100.00%> (ø)
src/algorithms/contractions/localoperator.jl 94.98% <94.54%> (+16.40%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yue-Zhengyuan
Copy link
Member

Yue-Zhengyuan commented Sep 13, 2025

I've added tests on contract_local_operator and contract_local_norm (I think these are relevant only for PEPS expectation values), and fixed some space mismatch errors caused by wrong generated @tensor indices.

Copy link
Member Author

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting that together and fixing this. I don't have too much time this week, so if you want to change the error messages to be more informative and merge this, I'm definitely happy with that.

Yue-Zhengyuan
Yue-Zhengyuan previously approved these changes Sep 16, 2025
Copy link
Member

@Yue-Zhengyuan Yue-Zhengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some minor changes to the docstring and error messages. The format check error seems to be an issue with GitHub. OK to merge for me now.

@lkdvos
Copy link
Member Author

lkdvos commented Sep 16, 2025

Should resolve itself in a bit, I'll try and retrigger the workflows this afternoon.

julia-actions/setup-julia#350

@Yue-Zhengyuan Yue-Zhengyuan enabled auto-merge (squash) September 16, 2025 07:07
@Yue-Zhengyuan Yue-Zhengyuan dismissed their stale review September 16, 2025 07:41

I just found out there are issues with PEPOs with a non-trivial unit cell. I'll try to fix it.

Yue-Zhengyuan
Yue-Zhengyuan previously approved these changes Sep 16, 2025
Copy link
Member

@Yue-Zhengyuan Yue-Zhengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed physicalspace for PEPO to return the physical codomain space in the bottom layer directly as a Nrow x Ncol matrix (no 3rd dimension). The original implementation returns something strange (e.g. for an 2 x 2 x 1 PEPO, it returns a length-2 vector). Things should be fine now. @lkdvos You may want to take a final look before merging.

@Yue-Zhengyuan Yue-Zhengyuan merged commit 76344b9 into master Sep 17, 2025
51 checks passed
@Yue-Zhengyuan Yue-Zhengyuan deleted the ld-pepo-dm branch September 17, 2025 03:36
@Yue-Zhengyuan Yue-Zhengyuan mentioned this pull request Sep 17, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants