Skip to content

Stabilize C4v AD optimization test#353

Merged
leburgel merged 1 commit intomasterfrom
lb/fix_qr_ctm_test
Apr 10, 2026
Merged

Stabilize C4v AD optimization test#353
leburgel merged 1 commit intomasterfrom
lb/fix_qr_ctm_test

Conversation

@leburgel
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@Yue-Zhengyuan Yue-Zhengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge once the tests pass. I heard this is just because some random seeds are particularly awful in a way that can be theorized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yue-Zhengyuan
Copy link
Copy Markdown
Member

There are a bunch of "Node.js 20 actions are deprecated" warnings in the CI action log.

@leburgel
Copy link
Copy Markdown
Member Author

leburgel commented Apr 10, 2026

Where do you see these exactly? All I see is deprecation warnings from the MatrixAlgebraKit.jl decompositions, since all LAPACK_-specific algorithm names were deprecated in v0.6.5, which we should address next.

EDIT: never mind, I see them. Not sure if we actually need to do anything about this tough, probably we'll just need an update of action versions used in https://github.com/QuantumKitHub/QuantumKitHubActions/, which will then solve the issue here?

@Yue-Zhengyuan
Copy link
Copy Markdown
Member

It's @lkdvos's work then, I guess...

@leburgel leburgel merged commit 2171fb1 into master Apr 10, 2026
61 of 63 checks passed
@leburgel leburgel deleted the lb/fix_qr_ctm_test branch April 10, 2026 16:58
@lkdvos
Copy link
Copy Markdown
Member

lkdvos commented Apr 13, 2026

Commenting on the actions here: I will/have updated most of them, but this is also related to some downstream updates that are not in my hands (and will be updated automatically), so this can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants