Remove :diffgauge differentiation mode#370
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
approved these changes
May 1, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Looks good, thanks!
It's indeed even more obvious now that selecting iterscheme = ::Symbol is a bit strange, since there is only one option.
We could probably get rid of that thing entirely, but for sure in a follow-up PR.
Thanks for this quick and clean PR, makes it very easy to review :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all uses of the
:diffgaugedifferentiation mode which differentiates the gauge-fixing routine and is generally slower and more difficult to work with. Closes #367.As a follow-up, we should at some point thing about making the current gauge-fixing scheme compatible with real tensors or maybe switch the gauge-fixing scheme to just fix the decompositions. (That seems to work in other codes.)