Skip to content

Export isstrided#31

Merged
Jutho merged 1 commit intoQuantumKitHub:mainfrom
lkdvos:ld-isstrided
Oct 7, 2024
Merged

Export isstrided#31
Jutho merged 1 commit intoQuantumKitHub:mainfrom
lkdvos:ld-isstrided

Conversation

@lkdvos
Copy link
Copy Markdown
Member

@lkdvos lkdvos commented Oct 7, 2024

Closes #30

@Jutho
Copy link
Copy Markdown
Member

Jutho commented Oct 7, 2024

Is this not exported in StridedViews?

@lkdvos
Copy link
Copy Markdown
Member Author

lkdvos commented Oct 7, 2024

It is, but it does not get pushed through.
I guess the question is more something along the lines of:
Should an end-user, that requires Strided.jl, also import StridedViews.jl?
Right now, all exports from StridedViews (except for isstrided) are just re-exported, and it is quite convenient to not have to import both. Additionally, I do feel like isstrided could be part of the public interface.

@Jutho Jutho merged commit 39bc28c into QuantumKitHub:main Oct 7, 2024
@lkdvos lkdvos deleted the ld-isstrided branch October 7, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-export StridedViews.isstrided

2 participants