Skip to content

PtrArrays extension#16

Merged
Jutho merged 5 commits intomainfrom
ptrarrays
Mar 31, 2025
Merged

PtrArrays extension#16
Jutho merged 5 commits intomainfrom
ptrarrays

Conversation

@lkdvos
Copy link
Copy Markdown
Member

@lkdvos lkdvos commented Mar 31, 2025

The new version seems to have broken the compatibility with PtrArrays.jl, since reshape(::PtrArray) produces a lazy reshaped array, which then no longer is a subtype of DenseArray.

Here I simply circumvent that issue by correctly reshaping the PtrArray manually, but probably it is also fair to be slightly more conservative and only define the _normalizeparent function for Array -- making this functionality more opt-in instead of opt-out.
@Jutho if you agree, I'll address that in a separate PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (f4d8121) to head (19e3b1b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   91.70%   91.78%   +0.08%     
==========================================
  Files           4        5       +1     
  Lines         205      207       +2     
==========================================
+ Hits          188      190       +2     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jutho
Copy link
Copy Markdown
Member

Jutho commented Mar 31, 2025

I would be in favor of only doing the _normalizeparent for Array instances. I think I had that as a comment on the previous PR, but then since it wasn't changed afterwards, I didn't want to push for it.

@Jutho Jutho merged commit c82d7c8 into main Mar 31, 2025
16 checks passed
@lkdvos lkdvos deleted the ptrarrays branch March 31, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants