Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 91.70% 91.78% +0.08%
==========================================
Files 4 5 +1
Lines 205 207 +2
==========================================
+ Hits 188 190 +2
Misses 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I would be in favor of only doing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version seems to have broken the compatibility with
PtrArrays.jl, sincereshape(::PtrArray)produces a lazy reshaped array, which then no longer is a subtype ofDenseArray.Here I simply circumvent that issue by correctly reshaping the
PtrArraymanually, but probably it is also fair to be slightly more conservative and only define the_normalizeparentfunction forArray-- making this functionality more opt-in instead of opt-out.@Jutho if you agree, I'll address that in a separate PR.