Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
Author
|
Also got Buildkite working correctly, finally... |
Jutho
reviewed
Feb 26, 2026
Jutho
reviewed
Feb 26, 2026
| @test B == A | ||
| CUDA.@allowscalar begin | ||
| @test B == A | ||
| end |
Member
There was a problem hiding this comment.
I was wondering about how this worked, i.e. what method it was dispatched to. It's probably some AbstractArray fallback in Base?
Member
Author
There was a problem hiding this comment.
I think so, yes. Another option is to copy these back to the CPU, but I worried we wouldn't be able to distentangle a bug in the copying back vs something with the StridedView itself...
Jutho
reviewed
Feb 26, 2026
| @testset "ROCArrays with StridedView" begin | ||
| @testset for T in (Float64, ComplexF64) | ||
| A = AMDGPU.randn!(T, 10, 10, 10, 10) | ||
| A = ROCArray(randn(T, 10, 10, 10, 10)) |
Member
There was a problem hiding this comment.
Don't know if this also exists?
Suggested change
| A = ROCArray(randn(T, 10, 10, 10, 10)) | |
| A = ROCArray.randn(T, 10, 10, 10, 10) |
Member
Author
There was a problem hiding this comment.
It doesn't work for complex element types unfortunately
Jutho
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason BuildKite didn't run AMDGPU tests and didn't catch this 😞