Conversation
lkdvos
commented
Apr 16, 2026
Member
Author
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
I'm really not sure what causes the AMD errors, I don't think this changes anything there :(
Member
|
It's nothing you've done, AMDGPU CI is notoriously flaky for this. I've retried that run. |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
Author
Member
|
AMDGPU downgraded their CI back to ROCm 6, let's see if things are a little less flaky now |
kshyatt
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modernizes the test workflow by using the
sourcesandworkspaces, and I separated out the JET tests to avoid having nightly fail on that. Unfortunately, AMDGPU still seems to be broken on nightly, but that is probably not something we want to guard against?The compat check workflow does not seem to like the
sourcesandworkspaces, and I don't know if I have the time or energy to figure out why and if there is anything to do about this. If this is okay for everyone, I would like to just ignore that for now.